Re: REINDEX filtering in the backend

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Julien Rouhaud <rjuju123(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: REINDEX filtering in the backend
Date: 2019-08-28 05:09:51
Message-ID: 20190828050951.GH1965@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Aug 28, 2019 at 02:02:08PM +0900, Michael Paquier wrote:
> + index = index_open(indexOid, AccessShareLock);
> + numAtts = index->rd_index->indnatts;
> + index_close(index, AccessShareLock);
> Wouldn't it be better to close that after doing the scan?
>
> Nit: I am pretty sure that this should be indented.
>
> Could you add tests with REINDEX CONCURRENTLY?

Bonus: support for reindexdb should be added. Let's not forget about
it.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2019-08-28 05:36:45 Re: pgbench - implement strict TPC-B benchmark
Previous Message Michael Paquier 2019-08-28 05:02:08 Re: REINDEX filtering in the backend