Re: wrong Visual Studio Edition 's name

From: Takuma Hoshiai <hoshiai(at)sraoss(dot)co(dot)jp>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-docs(at)postgresql(dot)org
Subject: Re: wrong Visual Studio Edition 's name
Date: 2019-08-21 04:03:01
Message-ID: 20190821130301.43bded469ed4b4fdb879ae56@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

On Tue, 20 Aug 2019 19:19:01 +0900
Michael Paquier <michael(at)paquier(dot)xyz> wrote:

> On Tue, Aug 20, 2019 at 03:38:28PM +0900, Takuma Hoshiai wrote:
> > I have attached a patch. The word of "Express" existed in four
> > places, they will are fixed by this patch.
>
> - These compilers can be either from <productname>Visual Studio</productname>,
> - <productname>Visual Studio Express</productname> or some versions of the
> - <productname>Microsoft Windows SDK</productname>. If you do not already have a
> - <productname>Visual Studio</productname> environment set up, the easiest
> - ways are to use the compilers from <productname>Visual Studio Express 2019
> - for Windows Desktop</productname> or those in the <productname>Windows SDK
> + These compilers can be either from <productname>Visual Studio</productname>
> + or some versions of the <productname>Microsoft Windows SDK</productname>.
> + If you do not already have a <productname>Visual Studio</productname>
> + environment set up, the easiest ways are to use the compilers
> + from <productname>Visual Studio 2019</productname>
> + or those in the <productname>Windows SDK
> 10</productname>, which are both free downloads from Microsoft.
>
> I may be missing something, but this refers to all the possible
> flavors of VS where compilers are available, hence mentioning Visual
> Studio Express is still correct when going through our full supported
> range from VS 2013 to VS 2019, no? That's why I said only two places
> need to be fixed, as this area is fine.

Yes, Express edition is contained by supported range. But my understanding
is that other Edition are also same. The reason for changing above sentence,
was that I thought that we don't need to specify Express edition only.

The above original sentence is no problem too, so I have reattached a patch,
which is fixed "Express 2019" only.

> --
> Michael

--
Takuma Hoshiai <hoshiai(at)sraoss(dot)co(dot)jp>

Attachment Content-Type Size
vs_edition_fix_v2.patch application/octet-stream 1.5 KB

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message PG Doc comments form 2019-08-21 08:12:33 max_standby_streaming_delay : explanation is repeated directly after first explanation
Previous Message Joshua D. Drake 2019-08-20 16:03:09 Re: readability changes to postgres.sgml