| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, jungleboogie0(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE' |
| Date: | 2019-08-21 07:27:24 |
| Message-ID: | 20190821072724.GB26424@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Tue, Aug 20, 2019 at 07:07:49PM -0700, Andres Freund wrote:
> On 2019-08-21 10:58:54 +0900, Michael Paquier wrote:
>> @@ -246,6 +232,18 @@ ParallelSlotsSetup(const char *dbname, const char *host, const char *port,
>> {
>> conn = connectDatabase(dbname, host, port, username, prompt_password,
>> progname, echo, false, true);
>> +
>> + /*
>> + * Fail immediately if trying to use an index in an unsupported
>> + * range. Doing a hard exit here is not beautiful, but that's
>> + * not worth complicating the logic.
>> + */
>
> "that's not worth" sounds odd to me in the above sentence. I don't quite
> get the half-hearted rewrite of the comment from pgbench.c.
What about just keeping the first sentence then? And this gives:
"Fail immediately if trying to use an index in an unsupported range."
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-08-21 07:36:19 | Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE' |
| Previous Message | Sandeep Thakkar | 2019-08-21 07:24:55 | Re: Postgres 11.5.1 failed installation |