| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, vignesh C <vignesh21(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Unused header file inclusion |
| Date: | 2019-08-19 14:22:14 |
| Message-ID: | 20190819142214.GA9703@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-Aug-18, Tom Lane wrote:
> I wrote:
> > (My headerscheck script is missing that header; I need to update it to
> > match the latest version of cpluspluscheck.)
>
> I did that, and ended up with the attached. I'm rather tempted to stick
> this into src/tools/ alongside cpluspluscheck, because it seems to find
> rather different trouble spots than cpluspluscheck does. Thoughts?
Yeah, let's include this. I've written its equivalent a couple of times
already. (My strategy is just to compile the .h file directly though,
which creates a .gch file, rather than writing a temp .c file.)
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-08-19 14:28:29 | Re: psql \r command is working? |
| Previous Message | Sergei Kornilov | 2019-08-19 14:17:44 | psql \r command is working? |