Re: Small patch to fix build on Windows

Hello.

At Thu, 08 Aug 2019 12:15:38 +0900 (Tokyo Standard Time), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in <20190808(dot)121538(dot)87367461(dot)horikyota(dot)ntt(at)gmail(dot)com>
> At Wed, 7 Aug 2019 12:14:48 +0300, Dmitry Igrishin <dmitigr(at)gmail(dot)com> wrote in <CAAfz9KPVff92Np51DvvCDvqvxVchiuuvJCzz56qtM=N0SUnG8A(at)mail(dot)gmail(dot)com>
> > > - if ($lib =~ m/\s/)
> > > - {
> > > - $lib = '&quot;' . $lib . "&quot;";
> > > - }
> > > + # Since VC automatically quotes paths specified as the data of
> > > + # <AdditionalDependencies> in VC project file, it's mistakably
> > > + # to quote them here. Thus, it's okay if $lib contains spaces.
..
> I doubt that some older versions of VC might need it. I confirmed
> that the extra &quot; actually harms at least VC2019 and the code
> removal in the patch works. As for the replace comment, I'm not
> sure it is needed since I think quoting is not the task for
> AddLibrary/AddIncludeDir in the first place (and AddIncludeDir
> doesn't have the same comment).
>
> Now I'm trying to install VS2015 into my alomost-filled-up disk..

I confirmed that VC2015 works with the above diff. So the patch
is overall fine with me.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center