Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Ian Barwick <ian(dot)barwick(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions
Date: 2019-08-06 05:05:26
Message-ID: 20190806050526.GE32256@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Aug 05, 2019 at 10:16:16PM -0400, Stephen Frost wrote:
> * Ian Barwick (ian(dot)barwick(at)2ndquadrant(dot)com) wrote:
>> On 8/6/19 9:52 AM, Stephen Frost wrote:> Greetings,
>>> * Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
>>>> Concretely, how about the attached?
>>>>
>>>> (Digging around in config.sgml, I found that last-one-wins is stated,
>>>> but only in the context of one include file overriding another.
>>>> That's not *directly* a statement about what happens within a single
>>>> file, and it's in a different subsection anyway, so repeating the
>>>> info in 19.1.2 doesn't seem unreasonable.)
>>>
>>> Agreed.
>>
>> +1.

I have read the latest patch from Tom and I have a suggestion about
this part:
+ and its settings take effect in the same way. Settings
+ in <filename>postgresql.auto.conf</filename> override those
+ in <filename>postgresql.conf</filename>.

It seems to me that we should mention included files here, as any
settings in postgresql.auto.conf override these as well.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-08-06 05:17:54 Re: Putting kerberos/ldap logs somewhere useful
Previous Message Amit Kapila 2019-08-06 05:02:52 Re: POC: Cleaning up orphaned files using undo logs