Re: Unused struct member in pgcrypto pgp.c

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Unused struct member in pgcrypto pgp.c
Date: 2019-07-31 01:23:59
Message-ID: 20190731012359.GF1577@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 30, 2019 at 05:48:49PM +0200, Daniel Gustafsson wrote:
> In contrib/pgcrypto/pgp.c we have a struct member int_name in digest_info which
> isn’t used, and seems to have never been used (a potential copy/pasteo from the
> cipher_info struct?). Is there a reason for keeping this, or can it be removed
> as per the attached?

I don't see one as this is not used in any logic for the digest
lookups. So agreed and applied. This originally comes from e94dd6a.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2019-07-31 01:32:10 Re: tap tests driving the database via psql
Previous Message Amit Langote 2019-07-31 00:51:48 Re: Attached partition not considering altered column properties of root partition.