| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: using explicit_bzero |
| Date: | 2019-07-30 05:08:43 |
| Message-ID: | 20190730050843.GI1742@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jul 29, 2019 at 11:30:53AM +0200, Peter Eisentraut wrote:
> Another patch, with various fallback implementations.
I have spotted some issues with this patch:
1) The list of port files @pgportfiles in Mkvcbuild.pm has not been
updated with the new file explicit_bzero.c, so the compilation would
fail with MSVC.
2) pg_config.h.win32 does not include the two new flags (same as
https://www.postgresql.org/message-id/20190624050850.GE1637@paquier.xyz)
3) What about CreateRole() and AlterRole() which can manipulate a
password in plain format before hashing? (same message as previous
point).
Nit: src/port/explicit_bzero.c misses its IDENTIFICATION tag.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2019-07-30 05:58:05 | Re: using explicit_bzero |
| Previous Message | Dilip Kumar | 2019-07-30 05:03:38 | Re: POC: Cleaning up orphaned files using undo logs |