| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Ian Barwick <ian(dot)barwick(at)2ndquadrant(dot)com>, Sergei Kornilov <sk(at)zsrv(dot)org>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] minor bugfix for pg_basebackup (9.6 ~ ) |
| Date: | 2019-07-24 23:53:02 |
| Message-ID: | 20190724235302.GB6000@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 24, 2019 at 11:23:30AM -0400, Alvaro Herrera wrote:
> Heh, yesterday I revised the original patch as attached and was about to
> push when the bell rang. I like this one because it keeps the comment
> to one line and it mentions the function name in charge of the
> validation (useful for grepping later on). It's a bit laconic because
> of the long function name and the desire to keep it to one line, but it
> seems sufficient to me.
Looks fine to me. A nit: addition of braces for the if block. Even
if that a one-liner, there is a comment so I think that this makes the
code more readable.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Imai, Yoshikazu | 2019-07-25 00:01:57 | RE: seems like a bug in pgbench -R |
| Previous Message | David Rowley | 2019-07-24 23:52:33 | Re: Statistical aggregate functions are not working with PARTIAL aggregation |