Re: pgsql: Improve stability of TAP test for synchronous replication

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Improve stability of TAP test for synchronous replication
Date: 2019-07-24 22:56:51
Message-ID: 20190724225651.GA6000@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Wed, Jul 24, 2019 at 02:17:14PM -0400, Andrew Dunstan wrote:
> This broke our perl coding rules:
>
> ./src/test/recovery/t/007_sync_rep.pl: Subroutine
> "start_standby_and_wait" does not end with "return" at line 33,
> column 1. See page 197 of PBP. (Severity: 5)

Fixed, thanks. Indeed I can see that pgperlcritic complains here, and
I have added a call in my pre-commit scripts for the future.
--
Michael

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2019-07-25 01:54:45 pgsql: Fix system column accesses in ON CONFLICT ... RETURNING.
Previous Message Michael Paquier 2019-07-24 22:56:24 pgsql: Fix failure with pgperlcritic from the TAP test of synchronous r