Re: Custom table AMs need to include heapam.h because of BulkInsertState

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Custom table AMs need to include heapam.h because of BulkInsertState
Date: 2019-07-16 09:44:11
Message-ID: 20190716094411.GI1439@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi David,

On Wed, Jul 10, 2019 at 09:40:59PM +1200, David Rowley wrote:
> On Wed, 3 Jul 2019 at 19:35, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> This has been reverted as of f5db56f, still it seems to me that this
>> was moving in the right direction.
>
> I've pushed this again, this time with the cleanup code done in the
> right order.

I have spent some time lately analyzing f7c830f as I was curious about
the logic behind it, and FWIW the result looks good. Thanks!
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2019-07-16 10:42:06 Re: SegFault on 9.6.14
Previous Message Kyotaro Horiguchi 2019-07-16 09:16:40 Re: Comment fix of config_default.pl