Re: pg_stat_database update stats_reset only by pg_stat_reset

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Daniel Verite <daniel(at)manitou-mail(dot)org>
Cc: 张连壮 <lianzhuangzhang(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_stat_database update stats_reset only by pg_stat_reset
Date: 2019-07-12 04:51:50
Message-ID: 20190712045150.GI2149@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 11, 2019 at 04:34:20PM +0200, Daniel Verite wrote:
> I can understand why you'd want that resetting the stats for a single object
> would not reset the per-database timestamp, but this would revert a 8+ years
> old decision that seems intentional and has apparently not been criticized
> since then (based on searching for pg_stat_reset_single_table_counters in
> the archives) . More opinions are probably needed in favor of this
> change (or against, in which case the fate of the patch might be a
> rejection).

I agree with Daniel that breaking an 8-year-old behavior may not be of
the taste of folks relying on the current behavior, particularly
because we have not had complains about the current behavior being
bad. So -1 from me.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robins Tharakan 2019-07-12 04:52:53 Re: Brazil disables DST - 2019b update
Previous Message Amit Langote 2019-07-12 04:49:00 Re: Excessive memory usage in multi-statement queries w/ partitioning