From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
---|---|
To: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: doc: improve PG 12 to_timestamp()/to_date() wording |
Date: | 2019-07-06 20:24:25 |
Message-ID: | 20190706202425.GA16933@telsasoft.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Apr 30, 2019 at 07:14:04PM -0500, Justin Pryzby wrote:
> On Tue, Apr 30, 2019 at 09:48:14PM +0300, Alexander Korotkov wrote:
> > I'd like to add couple of comments from my side.
>
> > > - returns an error because the second template string space is consumed
> > > - by the letter <literal>J</literal> in the input string.
> > > + returns an error because the second space in the template string consumes
> > > + the letter <literal>M</literal> from the input string.
> >
> > Why <literal>M</literal>? There is no letter "M" is input string.
> > The issue here is that we already consumed "J" from "JUN" and trying
> > to match "UN" to "MON". So, I think we should live
> > <literal>J</literal> here. The rest of this change looks good.
>
> Seems like I confused myself while resolving rebase conflict.
>
> Thanks for checking.
Find attached updated patch, which seems to still be needed.
This was subsumed and now extracted from a larger patch, from which Michael at
one point applied a few hunks.
I have some minor updates based on review from Andres, but there didn't seem to
be much interest so I haven't pursued it.
https://www.postgresql.org/message-id/20190520182001.GA25675%40telsasoft.com
Justin
Attachment | Content-Type | Size |
---|---|---|
v3-0008-Clean-up-language-in-cf984672-Improve-behavior-of.patch | text/x-diff | 2.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2019-07-06 20:59:20 | Re: CREATE STATISTICS documentation bug |
Previous Message | Jeff Davis | 2019-07-06 19:26:06 | Re: range_agg |