Re: Hypothetical indexes using BRIN broken since pg10

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Julien Rouhaud <rjuju123(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Hypothetical indexes using BRIN broken since pg10
Date: 2019-06-27 18:14:47
Message-ID: 20190627181447.GA30619@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi, thanks for the patch.

On 2019-Jun-27, Julien Rouhaud wrote:

> I just realized that 7e534adcdc7 broke support for hypothetical
> indexes using BRIN am. Attached patch fix the issue.
>
> There's no interface to provide the hypothetical pagesPerRange value,
> so I used the default one, and used simple estimates.

I think it would look nicer to have a routine parallel to brinGetStats()
(brinGetStatsHypothetical?), instead of polluting selfuncs.c with these
gory details.

This seems back-patchable ...

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2019-06-27 18:20:35 Re: Fix doc bug in logical replication.
Previous Message Robert Haas 2019-06-27 18:09:02 Re: POC: Cleaning up orphaned files using undo logs