| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, stepya(at)ukr(dot)net, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #15724: Can't create foreign table as partition |
| Date: | 2019-06-27 16:33:32 |
| Message-ID: | 20190627163332.GA30978@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 2019-Jun-26, Amit Langote wrote:
> On Tue, Jun 25, 2019 at 9:57 PM Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> > BTW I'm now thinking that those ERRCODE_INVALID_OBJECT_DEFINITION codes
> > are not really the correct ones; I mean, it would be the right one to
> > use for the unexpected relkind condition, but for the other cases I
> > think we should use ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE instead.
>
> Agreed.
I had second thoughts about this one -- ERRCODE_WRONG_OBJECT_TYPE seems
more appropriate, so I used that.
I also tweaked Fujita-san's recently committed documentation addition.
Pushed to 11 and master. Thanks!
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-06-27 16:47:50 | Re: BUG #15724: Can't create foreign table as partition |
| Previous Message | Tom Lane | 2019-06-27 16:20:35 | Re: BUG #15827: Unable to connect on Windows using pg_services.conf using Python psycopg2 |