| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: check_recovery_target_lsn() does a PG_CATCH without a throw |
| Date: | 2019-06-20 16:05:19 |
| Message-ID: | 20190620160519.aga3ozrsxib5lmnh@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2019-06-20 15:42:14 +0200, Peter Eisentraut wrote:
> On 2019-06-12 13:16, Peter Eisentraut wrote:
> > I haven't figured out the time zone issue yet, but I guess the solution
> > might involve moving some of the code from check_recovery_target_time()
> > to assign_recovery_target_time().
>
> I think that won't work either. What we need to do is postpone the
> interpretation of the timestamp string until after all the GUC
> processing is done. So check_recovery_target_time() would just do some
> basic parsing checks, but stores the string. Then when we need the
> recovery_target_time_value we do the final parsing. Then we can be sure
> that the time zone is all set.
That sounds right to me.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2019-06-20 16:14:00 | Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.) |
| Previous Message | Robert Haas | 2019-06-20 16:02:30 | Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.) |