Re: pg_dump multi VALUES INSERT

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Surafel Temesgen <surafel3000(at)gmail(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump multi VALUES INSERT
Date: 2019-06-14 22:27:29
Message-ID: 20190614222729.GA2080@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2019-Jun-14, Fabien COELHO wrote:

>
> Hello Alvaro,
>
> > > Shouldn't the --rows-per-insert option also be available via pg_dumpall?
> > > All the other options for switching between COPY and INSERT are
> > > settable in pg_dumpall.
> >
> > Uh, yeah, absolutely.
> >
> > Surafel, are you in a position to provide a patch for that quickly?
>
> End of the week, more time, easy enough and I should have seen the issue
> while reviewing. Patch attached.

Hello Fabien

Thanks for producing a fix so quickly. David Rowley mentioned a couple
of issues OOB (stanzas were put in the wrong places, when considering
alphabetical ordering and such). It's pushed now.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2019-06-14 22:31:52 Re: fix psql \conninfo & \connect when using hostaddr
Previous Message Andrew Gierth 2019-06-14 22:14:09 Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.)