| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Backend specific ifdefs in sha2.h |
| Date: | 2019-06-13 08:29:27 |
| Message-ID: | 20190613082927.GA1799@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 13, 2019 at 09:32:28AM +0200, Daniel Gustafsson wrote:
> The #ifdef guards in sha2.h are using USE_SSL when they in fact are guarding
> the inclusion of OpenSSL specific code. This has never caused any issues as
> there only is a single supported TLS backend in core so far, but since we’ve
> spent a significant amount of energy on making the TLS backend non-hardcoded
> it seems we should fix this too. The Makefile around sha2.c/sha2_openssl.c is
> already testing for openssl rather than ssl (which given src/Makefile.global
> variables makes perfect sense of course).
Right, good catch. I would not back-patch that though as currently
USE_SSL <=> USE_OPENSSL. Any suggestions or thoughts from others?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2019-06-13 08:31:23 | Re: Backend specific ifdefs in sha2.h |
| Previous Message | Alexander Lakhin | 2019-06-13 08:28:42 | Re: Fix inconsistencies for v12 (pass 2) |