| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_basebackup failure after setting default_table_access_method option |
| Date: | 2019-06-11 06:49:03 |
| Message-ID: | 20190611064903.ipuawi3dmz2wkdo4@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2019-06-11 14:56:36 +0900, Michael Paquier wrote:
> On Mon, Jun 10, 2019 at 10:33:37PM -0700, Andres Freund wrote:
> > Yea, that's where the default_table_access_method code originates from,
> > obviously. I'll backpatch the default_text_search_config fix separately
> > (and first).
>
> So you are just planning to add a check on MyDatabaseId for both? No
> objections to that.
Well, all four. Given it's just copied code I don't see much code in
splitting the commit anymore.
I noticed some other uglyness: check_timezone calls interval_in(),
without any checks. Not a huge fan of doing all that in postmaster, even
leaving the wrong error reporting aside :(. But that seems like a
plenty different enough issue to fix it separately, if we decide we want
to do so.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Khandekar | 2019-06-11 06:54:07 | Re: Minimal logical decoding on standbys |
| Previous Message | Fabien COELHO | 2019-06-11 06:36:55 | Re: pgbench rate limiting changes transaction latency computation |