| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Michael Banck <michael(dot)banck(at)credativ(dot)de>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Why does pg_checksums -r not have a long option? |
| Date: | 2019-06-06 09:01:21 |
| Message-ID: | 20190606090121.GC10729@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 05, 2019 at 10:31:54PM +0200, Peter Eisentraut wrote:
> I think -r/--relfilenode was actually a good suggestion. Because it
> doesn't actually check a *file* but potentially several files (forks,
> segments). The -f naming makes it sound like it operates on a specific
> file.
Hmm. I still tend to prefer the -f/--filenode interface as that's
more consistent with what we have in the documentation, where
relfilenode gets only used when referring to the pg_class attribute.
You have a point about the fork types and extra segments, but I am not
sure that --relfilenode defines that in a better way than --filenode.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2019-06-06 09:08:25 | Re: PGCOLOR? (Re: pgsql: Unified logging system for command-line programs) |
| Previous Message | Etsuro Fujita | 2019-06-06 08:58:00 | Re: postgres_fdw: oddity in costing presorted foreign scans with local stats |