| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Mark Dilger <hornschnorter(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: nitpick about poor style in MergeAttributes |
| Date: | 2019-06-04 20:18:30 |
| Message-ID: | 20190604201830.GA25150@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-May-23, Mark Dilger wrote:
> On Thu, May 23, 2019 at 5:24 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> > Looking closer, this code is not new as of v12. We have that since
> > e7b3349 which has introduced CREATE TABLE OF.
Yeah, I was not quite understanding why it was being blamed on a commit
that actually *removed* one other callsite that did the same thing. (I
didn't actually realize at the time that this bug was there, mind.)
> > Anyway, I think that assigning the result of list_delete_cell and
> > adding an assertion like in the attached are saner things to do.
Looks good to me.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2019-06-04 20:38:35 | Re: Binary support for pgoutput plugin |
| Previous Message | Alvaro Herrera | 2019-06-04 20:10:28 | Re: No mention of no CIC support for partitioned index in docs |