| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net> |
| Subject: | Re: coverage additions |
| Date: | 2019-06-04 20:07:17 |
| Message-ID: | 20190604200717.GA24195@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-Jun-04, Michael Paquier wrote:
> On Sat, Jun 01, 2019 at 12:55:47AM -0400, Alvaro Herrera wrote:
> > Ah, now I remember that I tried this before, but it requires some extra
> > packages installed in the machine I think, and those create running
> > services. Did you note that src/backend/libpq does not even list the
> > gssapi file?
>
> Do you mean the header file be-gssapi-common.h?
Actually, I meant be-gssapi-common.c, but I suppose having the file
appear at all would be dependent on whether the GSSAPI stuff is compiled
in, which seems to require yet another configure switch that we don't
have in the coverage machine.
But yeah, I think be-gssapi-common.h be in src/backend/libpq is against
our established practice and we should put it in src/include/libpq.
Which in turn makes me think that perhaps src/include/libpq/libpq.h
needs some splitting or something, because the be-openssl-common.c file
does not seem to have a corresponding header ...
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2019-06-04 20:10:28 | Re: No mention of no CIC support for partitioned index in docs |
| Previous Message | Dave Cramer | 2019-06-04 19:47:04 | Re: Binary support for pgoutput plugin |