Re: Sort support for macaddr8

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Melanie Plageman <melanieplageman(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Sort support for macaddr8
Date: 2019-06-04 17:49:23
Message-ID: 20190604174923.GS2480@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Greetings,

* Melanie Plageman (melanieplageman(at)gmail(dot)com) wrote:
> Peter and I implemented this small (attached) patch to extend
> abbreviated key compare sort to macaddr8 datatype (currently supported
> for macaddr).

Nice.

> I think that that seems like an improvement. I was thinking of
> registering this patch for the next commitfest. Is that okay?

Sure.

> I was just wondering what the accepted way to test and share
> performance numbers is for a small patch like this. Is sharing DDL
> enough? Do I need to use pg_bench?

Detailed (enough... doesn't need to include timing of every indivudal
query, but something like the average timing across 5 runs or similar
would be good) results posted to this list, with enough information
about how to reproduce the tests, would be the way to go.

The idea is to let others also test and make sure that they come up with
similar results to yours, and if they don't, ideally have enough
information to narrow down what's happening / what's different.

Thanks!

Stephen

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashwin Agrawal 2019-06-04 18:26:44 Re: Confusing error message for REINDEX TABLE CONCURRENTLY
Previous Message Andres Freund 2019-06-04 16:44:57 Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.)