Re: [PATCH] Simple typos fix

On Sun, Jun 02, 2019 at 04:42:57PM -0500, Justin Pryzby wrote:
> Thanks for finding these ; I think a few hunks are false positives and should
> be removed.

Yes, some of them are the changes in imath.c and snowball/, which we
include in Postgres but in reality are independent projects, so these
should be fixed in upstream instead, and Postgres will include those
fixes when merging with newer versions. If we were to fix those
issues ourselves, then we would likely create conflicts when merging
with newer versions of the upstream modules.

> A few more are debatable and could be correct either way:
>
> alloced - not an English word, but a technical one;

Indeed. The current wording is fine by me.

> delink - "unlink" is better for the filesystem operation, but I
> don't think "delink" is wrong for a list operation.
> dependees (?)

These terms could be used in programming.

> This'd
> define'd

Don't think it is much of a big deal to keep these as well.
"invokable" can be used in programming, and "cachable" is an alternate
spelling of "cacheable" based on some research.

> On Tue, May 28, 2019 at 08:17:18PM +0200, Andrea Gelmini wrote:
>> diff --git a/contrib/amcheck/verify_nbtree.c b/contrib/amcheck/verify_nbtree.c
>> index de0a98f6d9..ff13b0c9e7 100644
>> --- a/contrib/amcheck/verify_nbtree.c
>> +++ b/contrib/amcheck/verify_nbtree.c
>> @@ -1278,7 +1278,7 @@ bt_right_page_check_scankey(BtreeCheckState *state)
>> * Routines like _bt_search() don't require *any* page split interlock
>> * when descending the tree, including something very light like a buffer
>> * pin. That's why it's okay that we don't either. This avoidance of any
>> - * need to "couple" buffer locks is the raison d' etre of the Lehman & Yao
>> + * need to "couple" buffer locks is the reason d'etre of the Lehman & Yao
>
> I think this is wrong. The French phase is "raison d'etre".

French here. Note that an accent is missing on the first 'e' (être)
but we don't want non-ASCII characters in the code. So the current
wording is fine in my opinion.

> I think this is wrong. It should say "though". Or perhaps:
> * store at segment to which its start lsn belongs, but don't split over
> * multiple segments

I would replace it by "though", "tho" is not incorrect tho ;)

>> @@ -907,7 +907,7 @@ write_relmap_file(bool shared, RelMapFile *newmap,
>> * Make sure that the files listed in the map are not deleted if the outer
>> * transaction aborts. This had better be within the critical section
>> * too: it's not likely to fail, but if it did, we'd arrive at transaction
>> - * abort with the files still vulnerable. PANICing will leave things in a
>> + * abort with the files still vulnerable. Panicking will leave things in a
>
> Wrong ?

Yes, the suggestion is wrong. The comment refers to the elog level.

The original patch proposed 63 diffs. After the false positives are
removed, 21 remain, which I have now committed. You have done good
work in catching all these, by the way. Thanks for taking the time to
do so.
--
Michael