== PostgreSQL Weekly News - June 2, 2019 ==

== PostgreSQL Weekly News - June 2, 2019 ==

David Rowley is the newest committer. Congratulations!

== PostgreSQL Product News ==

psqlODBC 11.01.0000 released.
https://odbc.postgresql.org/docs/release.html

PostGIS 3.0.0alpaha2, the industry standard geographic information
system package for PostgreSQL, released.
https://postgis.net/2019/06/02/postgis-3.0.0alpha2/

pgAdmin4 4.7, a web- and native GUI control center for PostgreSQL, released.
https://www.pgadmin.org/docs/pgadmin4/dev/release_notes_4_7.html

postgres-checkup 1.1 "Young Owl", a tool that automates detailed health checks
of PostgreSQL clusters, released.
https://gitlab.com/postgres-ai-team/postgres-checkup/tags/1.1

pg_probackup 2.1.3, a utility to manage backup and recovery of PostgreSQL
database clusters, released.
https://github.com/postgrespro/pg_probackup

== PostgreSQL Jobs for June ==

http://archives.postgresql.org/pgsql-jobs/2019-06/

== PostgreSQL Local ==

pgibz will be held in Ibiza, Spain on June 19-23, 2019. The CfP is open.
https://pgibz.io/

Swiss PGDay 2019 will take place in Rapperswil (near Zurich) on June 28, 2019.
Registration is open.
http://www.pgday.ch/2019/

PostgresLondon 2019 will be July 2-3, 2019 with an optional training day on
July 1.
http://postgreslondon.org

PGConf.Brazil 2019 will take place August 1-3, 2019 in São Paulo.
http://pgconf.com.br

The first Austrian pgDay, will take place September 6, 2019 at the Hilton Garden
Inn in Wiener Neustadt.
https://pgday.at/en/

PostgresConf South Africa 2019 will take place in Johannesburg on October 8-9, 2019
The Call for Papers is open through June 30, 2019.
https://postgresconf.org/conferences/SouthAfrica2019

== PostgreSQL in the News ==

Planet PostgreSQL: http://planet.postgresql.org/

PostgreSQL Weekly News is brought to you this week by David Fetter

Submit news and announcements by Sunday at 3:00pm PST8PDT to david(at)fetter(dot)org(dot)

== Applied Patches ==

Peter Eisentraut pushed:

- doc: Fix generated column documentation. The old text still had an implicit
reference to the virtual behavior, which was not in the final patch. Author:
Tobias Bussmann <t(dot)bussmann(at)gmx(dot)net>
https://git.postgresql.org/pg/commitdiff/00ef6e3b28a8220f2dba881dbf56e3ba62f851bd

- Fix comment. This code block was copied/adapted from other similar places but
somehow the comment placement was changed so that it makes less sense.
https://git.postgresql.org/pg/commitdiff/a94fd139df975a006d1697d2a7180d3656222d4d

Michaël Paquier pushed:

- Fix typos in SQL scripts of pgcrypto. Author: Gurjeet Singh Discussion:
https://postgr.es/m/CABwTF4U_5kEnH93PXZEuEsZHuoSSuBEOqC6pian8vDfLZSQJNA@mail.gmail.com
https://git.postgresql.org/pg/commitdiff/af94ea7406f332567331a9b2525fae4b57c96061

- Fix some documentation about FKs and partitioned tables. This got forgotten in
f56f8f which has added foreign key support for partitioned tables. In
passing, add a mention about caveats applying to tables partitioned using
inheritance regarding indexes and foreign keys. Author: Paul A Jungwirth
Reviewed-by: Amit Langote, Michael Paquier Discussion:
https://postgr.es/m/CA+renyUuSmYgmZjKc_DfUNVZ0uttF91-FwhDVW3F7WEPj0jL5w@mail.gmail.com
https://git.postgresql.org/pg/commitdiff/f73293aba4d43e48707e361b2b1ef1465fef46e0

- Fix some documentation about access methods. Author: Guillaume Lelarge
Discussion:
https://postgr.es/m/CAECtzeWPz4JikzUqZdMjqPTe8dAP3nZxPD-58Y-Hhvirg0fF+A@mail.gmail.com
https://git.postgresql.org/pg/commitdiff/56b78626c7288fad498c0fae7fe4fd1f240ed13f

- Rework options of pg_checksums options for filenode handling. This makes the
tool consistent with the option set of oid2name, which has been historically
using -f for filenodes, and has more recently gained long options and
--filenode via 1aaf532. Reported-by: Peter Eisentraut Author: Fabien Coelho
Discussion:
https://postgr.es/m/97045260-fb9e-e145-a950-cf7d28c4eaea@2ndquadrant.com
https://git.postgresql.org/pg/commitdiff/fc115d0f9fc656967260815c031e0f25741428ae

- Fix documentation of check_option in information_schema.views. Support of
CHECK OPTION for updatable views has been added in 9.4, but the documentation
of information_schema never got the call even if the information displayed is
correct. Author: Gilles Darold Discussion:
https://postgr.es/m/75d07704-6c74-4f26-656a-10045c01a17e@darold.net
Backpatch-through: 9.4
https://git.postgresql.org/pg/commitdiff/0b8e0532c65c3a2d4b0e9c254efa022767bacceb

Bruce Momjian pushed:

- docs: PG 12 relnote wording fix. Reported-by: Gaby Schilders
https://git.postgresql.org/pg/commitdiff/3ceaed106d95e76c7dbfd41f5d83a163fd0d25c8

Andres Freund pushed:

- v12 release notes: Correct contributor name. Mea culpa.
https://git.postgresql.org/pg/commitdiff/d5ec46bf224d2ea1b010b2bc10a65e44d4456553

- Remove unnecessary (and wrong) forward declaration. Interestingly only C++
compilers have, so far, complained about this odd forward declaration. This
originated when IndexBuildCallback was defined in another file, but now is
completely unnecessary (but was wrong before too, cpluspluscheck just wouldn't
have noticed). Reported-By: Tom Lane Discussion:
https://postgr.es/m/53941.1559239260@sss.pgh.pa.us
https://git.postgresql.org/pg/commitdiff/13002bf0bcdf4900987684ca6ef7665a25aa692b

- Integrate cpluspluscheck into build system. Previously cpluspluscheck wouldn't
work in vpath builds, this commit fixes that. To make it easier to invoke,
there's a top-level cpluspluscheck target. Discussion:
https://postgr.es/20190530220244(dot)kiputcbl4gkl2oo6(at)alap3(dot)anarazel(dot)de
https://git.postgresql.org/pg/commitdiff/b1cd7ce23f40e1e443b3f2ab127bbe8348add678

Noah Misch pushed:

- In the pg_upgrade test suite, remove and recreate "tmp_check". This allows
"vcregress upgradecheck" to pass twice in immediate succession, and it's more
like how $(prove_check) works. Back-patch to 9.5, where pg_upgrade moved to
src/bin. Discussion:
https://postgr.es/m/20190520012436.GA1480421@rfd.leadboat.com
https://git.postgresql.org/pg/commitdiff/10b72deafea5972edcafb9eb3f97154f32ccd340

- In the pg_upgrade test suite, don't write to src/test/regress. When this suite
runs installcheck, redirect file creations from src/test/regress to
src/bin/pg_upgrade/tmp_check/regress. This closes a race condition in "make
-j check-world". If the pg_upgrade suite wrote to a given
src/test/regress/results file in parallel with the regular src/test/regress
invocation writing it, a test failed spuriously. Even without parallelism, in
"make -k check-world", the suite finishing second overwrote the other's
regression.diffs. This revealed test "largeobject" assuming @abs_builddir@ is
getcwd(), so fix that, too. Buildfarm client REL_10, released fifty-four days
ago, supports saving regression.diffs from its new location. When an older
client reports a pg_upgradeCheck failure, it will no longer include
regression.diffs. Back-patch to 9.5, where pg_upgrade moved to src/bin.
Reviewed (in earlier versions) by Andrew Dunstan. Discussion:
https://postgr.es/m/20181224034411.GA3224776@rfd.leadboat.com
https://git.postgresql.org/pg/commitdiff/40b132c1afbb4b1494aa8e48cc35ec98d2b90777

Álvaro Herrera pushed:

- Fix typo in message. I introduced the typo in source code in the course of
75445c1515ff. Repair.
https://git.postgresql.org/pg/commitdiff/a100974751baec7e13a527bf0c378ce8ef2787b6

- Make one message just like all its siblings.
https://git.postgresql.org/pg/commitdiff/d890fa812dd4620db0d092da1cd7cba01494cd21

- Fix double-phrase typo in message. New in 147e3722f7e5.
https://git.postgresql.org/pg/commitdiff/d22f885f895add7e0184b08a78ba92ff091e36c4

- Increase test coverage for worker_spi by ∞%. This test module was not getting
invoked, other than at compile time, limiting its usefulness -- and keeping
its coverage at 0%. Add a minimal regression test to ensure it runs on make
check-world; this makes it 92% covered (line-wise), which seems sufficient.
Author: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> Reviewed-by: Tom Lane
<tgl(at)sss(dot)pgh(dot)pa(dot)us> Discussion:
https://postgr.es/m/20190529193256.GA17603@alvherre.pgsql
https://git.postgresql.org/pg/commitdiff/4b3f1dd71b74f82dedbf37c331d0a444368c4009

Tomáš Vondra pushed:

- Make error logging in extended statistics more consistent. Most errors
reported in extended statistics are internal issues, and so should use elog().
The MCV list code was already following this rule, but the functional
dependencies and ndistinct coefficients were using a mix of elog() and
ereport(). Fix this by changing most places to elog(), with the exception of
input functions. This is a mostly cosmetic change, it makes the life a little
bit easier for translators, as elog() messages are not translated. So
backpatch to PostgreSQL 10, where extended statistics were introduced.
Author: Tomas Vondra Backpatch-through: 10 where extended statistics were
added Discussion: https://postgr.es/m/20190503154404.GA7478@alvherre.pgsql
https://git.postgresql.org/pg/commitdiff/fe415ff10408a1487d5773b47459306476ec58f0

Tom Lane pushed:

- Make our perfect hash functions be valid C++. While C is happy to cast "const
void *" to "const unsigned char *" silently, C++ insists on an explicit cast.
Since we put these functions into header files, cpluspluscheck whines about
that. Add the cast to pacify it. Discussion:
https://postgr.es/m/b517ec3918d645eb950505eac8dd434e@gaz-is.ru
https://git.postgresql.org/pg/commitdiff/9e58705a7f9728f10b2e0f0c9adc6e6ecff7486e

- Fix assorted header files that failed to compile standalone. We have a
longstanding project convention that all .h files should be includable with no
prerequisites other than postgres.h. This is tested/relied-on by
cpluspluscheck. However, cpluspluscheck has not historically been applied to
most headers outside the src/include tree, with the predictable consequence
that some of them don't work. Fix that, usually by adding missing #include
dependencies. The change in printf_hack.h might require some explanation:
without it, my C++ compiler whines that the function is unused. There's not
so many call sites that "inline" is going to cost much, and besides all the
callers are in test code that we really don't care about the size of. There's
no actual bugs being fixed here, so I see no need to back-patch. Discussion:
https://postgr.es/m/b517ec3918d645eb950505eac8dd434e@gaz-is.ru
https://git.postgresql.org/pg/commitdiff/7640f9312321ceba2af61f7017da7e64f0f7b667

- Fix C++ incompatibilities in plpgsql's header files. Rename some exposed
parameters so that they don't conflict with C++ reserved words. Back-patch to
all supported versions. George Tarasov Discussion:
https://postgr.es/m/b517ec3918d645eb950505eac8dd434e@gaz-is.ru
https://git.postgresql.org/pg/commitdiff/3f61b3205f1a8bd27909be97341f002db8842093

- Fix C++ incompatibilities in ecpg/preproc/ header files. There's probably no
need to back-patch this, since it seems unlikely that anybody would be
inserting C++ code into ecpg's preprocessor. Discussion:
https://postgr.es/m/b517ec3918d645eb950505eac8dd434e@gaz-is.ru
https://git.postgresql.org/pg/commitdiff/4f67858d3f210658d42f44fc674d2850581e572e

- Adjust ecpg expected-results files for commit 7640f9312. Mea culpa for not
rechecking check-world at the last step :-( Per buildfarm.
https://git.postgresql.org/pg/commitdiff/ec66ec8b21d3d779047313ac214fba7bcd29a97c

- Improve coverage of cpluspluscheck. Formerly, cpluspluscheck was only meant to
examine headers that we thought of as exported --- but its notion of what we
export was well behind the times. Let's just make it check *all* .h files,
except for a well-defined blacklist, instead. While at it, improve its
ability to use a C++ compiler other than g++, by scraping the CXX setting from
Makefile.global and making it possible to override the warning options used
(per suggestion from Andres Freund). Discussion:
https://postgr.es/m/b517ec3918d645eb950505eac8dd434e@gaz-is.ru
https://git.postgresql.org/pg/commitdiff/6f54b80edd88abd5665aa12fbcf10f846dd80939

- Un-break ecpg tests for Windows. Declaring a function "inline" still doesn't
work with Windows compilers (C99? what's that?), unless the macro provided by
pg_config.h is in-scope, which it is not in our ECPG test programs. So the
workaround I tried to use in commit 7640f9312 doesn't work for Windows.
Revert the change in printf_hack.h, and instead just blacklist that file in
cpluspluscheck --- since it's a not-installed test file, we don't really need
to verify its C++ cleanliness anyway.
https://git.postgresql.org/pg/commitdiff/10a53cae9993abae159abdc6a76e46f6aac120d1

- worker_spi needs a .gitignore file now.
https://git.postgresql.org/pg/commitdiff/135063e6f6ee61c7243801e9f4d702921ed53e06

- Clean up PL/Perl's handling of the _() macro. Perl likes to redefine the _()
macro: #ifdef CAN_PROTOTYPE #define _(args) args #else ... There was lots
not to like about the way we dealt with this before: 1. Instead of taking
care of the conflict centrally in plperl.h, we expected every one of its
ever-growing number of includers to do so. This is duplicative and error-prone
in itself, plus it means that plperl.h fails to meet the expectation of being
compilable standalone, resulting in macro-redefinition warnings in
cpluspluscheck. 2. We left _() with its Perl definition, meaning that if
someone tried to use it in any Perl-related extension, it would silently fail
to provide run-time translation. I don't see any live bugs of this ilk, but
it's clearly a hard-to-notice bug waiting to happen. So fix that by
centralizing the cleanup logic, making it match what we're already doing for
other macro conflicts with Perl. Since we only expect plperl.h to be included
by extensions not core code, we should redefine _() as dgettext() not
gettext().
https://git.postgresql.org/pg/commitdiff/032627ee7837f0baa539df7247e003dbaded2c90

David Rowley pushed:

- Fix incorrect parameter name in comment. Author: Antonin Houska Discussion:
https://postgr.es/m/22370.1559293357@localhost
https://git.postgresql.org/pg/commitdiff/72b6223f766d6ba9076d7b1ebdf05df75e83ba5c

== Pending Patches ==

Amit Kapila sent in another revision of a patch to allow undo actions to be
applied on rollbacks and discard unwanted undo.

Jan Chochol sent in a patch to bring the order of steps in DISCARD ALL
documentation in line with recent changes to the code.

Peter Eisentraut sent in a patch to add a "command" column to
pg_stat_progress_create_index.

Michaël Paquier sent in two revisions of a patch to fix a confusing error
message for REINDEX TABLE CONCURRENTLY.

Tom Lane sent in a patch to rearrange ALTER TABLE to avoid multi-operations
bugs.

Amit Khandekar sent in another revision of a patch to implement minimal logical
decoding on standbys.

Alexander Korotkov sent in a patch to implement the jsonpath .datetime() method.

Andrea Gelmini sent in a patch to fix many typos.

Thomas Munro sent in a patch to remove pg_collation.collversion, add
pg_depend.refobjversion, and track collation versions for indexes.

Mat Arye sent in a patch to call set_rel_pathlist_hook on part_rels.

Hubert Zhang sent in a patch to permit continuing to split batches when tuples
become diverse.

Haribabu Kommi sent in another revision of a patch to make PostgreSQL build with
Microsoft Visual Studio 2019.

Garick Hamlin sent in a patch to remove some dead stores from sha2.c.

Dmitry Dolgov sent in another revision of a patch to implement generic type
subscripting and use same for arrays and JSONB.

Dmitry Dolgov sent in another revision of a patch to implement index skip scans.

Donald Dong sent in a patch to print baserestrictinfo for varchar fields.

Álvaro Herrera sent in two revisions of a patch to increase coverage for
worker_spi.

Amit Langote sent in a patch to remove an ExecContextForcesOids reference from
src/backend/executor/nodeModifyTable.c.

James Coleman sent in another revision of a patch to implement incremental sort.

Michaël Paquier sent in a patch to replace some more references to things heap
with their generic table access method counterparts.

Michaël Paquier sent in a patch to fix some tab completion bugs in psql for
table access methods.

Binguo Bao sent in a patch to make TOAST decompression more efficient by
fetching only the chunks needed to decompress the slice.