| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>, "kommi(dot)haribabu(at)gmail(dot)com" <kommi(dot)haribabu(at)gmail(dot)com> |
| Subject: | Re: ACL dump ordering broken as well for tablespaces |
| Date: | 2019-05-23 01:51:18 |
| Message-ID: | 20190523015118.GA5870@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, May 22, 2019 at 06:35:31PM +0000, Bossart, Nathan wrote:
> The patch looks good to me.
Thanks for double-checking. I have applied and back-patched. The good
thing here is that there were zero conflicts.
> A bit of digging led me to the commit that removed databases and
> tablespaces from pg_init_privs [0] and to a related thread [1]. IIUC
> the problem is that using pg_init_privs for databases is complicated
> by the ability to drop and recreate the template databases.
I don't quite get this argument. If a user is willing to drop
template1, then it is logic to also drop its initial privilege entries
and recreate new ones from scratch. I think that this deserves a
closer lookup. For tablespaces, we are limited by the ability of not
sharing pg_init_privs?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-05-23 01:55:16 | Re: Minor typos and copyright year slippage |
| Previous Message | Andres Freund | 2019-05-23 01:46:13 | Re: Ought to use heap_multi_insert() for pg_attribute/depend insertions? |