| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
| Cc: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Compile using the Visual Studio 2019 |
| Date: | 2019-05-21 05:36:17 |
| Message-ID: | 20190521053617.GH1921@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, May 21, 2019 at 02:37:10PM +1200, David Rowley wrote:
> Maybe you could take a look at that and maybe sign up to review it?
Yes, that would be great. New VS environments are a pain to set up so
any input is welcome.
- # visual 2017 hasn't changed the nmake version to 15, so still
using the older version for comparison.
+ # visual 2019 hasn't changed the nmake version to
15, so still using the older version for comparison.
if ($major > 14)
I have not checked the other patch and I am pretty sure that you are
doing the same thing. Still, for the notice, this comment update is
incorrect as VS 2017 also marks nmake with version 15.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Paul A Jungwirth | 2019-05-21 05:36:33 | Re: clean up docs for v12 |
| Previous Message | Paul A Jungwirth | 2019-05-21 05:35:31 | Re: docs about FKs referencing partitioned tables |