| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Avoiding hash join batch explosions with extreme skew and weird stats |
| Date: | 2019-05-20 01:33:34 |
| Message-ID: | 20190520013334.pxh3azpu5ckduxjf@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2019-05-20 13:25:52 +1200, Thomas Munro wrote:
> In PostgreSQL, it's always inner = right, outer = left. You can see
> that reflected in plannodes.h and elsewhere:
>
> /* ----------------
> * these are defined to avoid confusion problems with "left"
> * and "right" and "inner" and "outer". The convention is that
> * the "left" plan is the "outer" plan and the "right" plan is
> * the inner plan, but these make the code more readable.
> * ----------------
> */
> #define innerPlan(node) (((Plan *)(node))->righttree)
> #define outerPlan(node) (((Plan *)(node))->lefttree)
I really don't understand why we don't just rename those fields.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-05-20 01:41:46 | Re: Calling PrepareTempTablespaces in BufFileCreateTemp |
| Previous Message | Michael Paquier | 2019-05-20 01:33:10 | Re: vacuumdb and new VACUUM options |