| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Sergei Kornilov <sk(at)zsrv(dot)org> |
| Cc: | Joe Wildish <joe-postgresql(dot)org(at)elusive(dot)cx>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Segfault on ANALYZE in SERIALIZABLE isolation |
| Date: | 2019-05-19 23:26:56 |
| Message-ID: | 20190519232656.mokwnozjgy25xqxl@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2019-05-18 18:12:31 +0300, Sergei Kornilov wrote:
> Seems table_beginscan_analyze (src/include/access/tableam.h) should not pass second argument as NULL.
As hopefully explained downthread, and in the commit message, that's not
really the concern. We shouldn't use the snapshot in the first place.
> PS: also I noticed in src/include/utils/snapshot.h exactly same
> comment for both SNAPSHOT_SELF and SNAPSHOT_DIRTY - they have no
> difference?
That was copy & paste mistake. Fixed. Also expanded the comments a
bit. Thanks for noticing!
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2019-05-20 00:22:11 | Re: Avoiding hash join batch explosions with extreme skew and weird stats |
| Previous Message | Thomas Munro | 2019-05-19 23:24:27 | Re: sample scans and predicate locking |