Re: copy-past-o comment in lock.h

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: John Naylor <john(dot)naylor(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: copy-past-o comment in lock.h
Date: 2019-05-07 08:00:24
Message-ID: 20190507080024.GP1499@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, May 07, 2019 at 03:41:50PM +0800, John Naylor wrote:
> Attached is an attempt to match surrounding code. More broadly,
> though, it seems the "ID info" comments belong with the SET_LOCKTAG_*
> macros rather than with the LockTagType enum members.

+ LOCKTAG_SPECULATIVE_TOKEN, /* for speculative insertion */
+ /* ID info for a speculative token is TRANSACTION info + token */
Shouldn't the first comment be just "speculative insertion"? And the
second one "ID info for a speculative insertion is transaction ID +
its speculative insert counter"?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2019-05-07 08:10:34 Re: BUG #15672: PostgreSQL 11.1/11.2 crashed after dropping a partition table
Previous Message Masahiko Sawada 2019-05-07 07:58:45 Re: New vacuum option to do only freezing