Re: pgsql: MSVC: Build ~35% faster by calling dumpbin just once per directo

From: Noah Misch <noah(at)leadboat(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: MSVC: Build ~35% faster by calling dumpbin just once per directo
Date: 2019-05-05 23:41:23
Message-ID: 20190505234123.GA979023@rfd.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Sun, May 05, 2019 at 06:13:47PM -0400, Tom Lane wrote:
> Noah Misch <noah(at)leadboat(dot)com> writes:
> > MSVC: Build ~35% faster by calling dumpbin just once per directory.
>
> I happened to notice that dory seems to have gotten no benefit at
> all from this patch, although the speed change is very apparent
> on some other MSVC critters such as whelk and woodlouse.
> Puzzling.

The author was using parallel builds (MSBFLAGS=/m), as was I. dory doesn't
seem to be doing so. I would have guessed more than zero improvement even
without parallelism. Puzzling, indeed.

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2019-05-06 06:38:34 pgsql: Remove reindex_catalog test from test schedules.
Previous Message Tom Lane 2019-05-05 22:13:47 Re: pgsql: MSVC: Build ~35% faster by calling dumpbin just once per directo