Re: Segfault when restoring -Fd dump on current HEAD

From: Andres Freund <andres(at)anarazel(dot)de>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Hubert Lubaczewski <depesz(at)depesz(dot)com>, pgsql-hackers mailing list <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
Subject: Re: Segfault when restoring -Fd dump on current HEAD
Date: 2019-04-25 19:54:06
Message-ID: 20190425195406.ykcfgv3barkdbpfp@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2019-04-25 15:05:47 -0400, Alvaro Herrera wrote:
> On 2019-Mar-10, Dmitry Dolgov wrote:
>
> > Then I guess we need to add the attached patch on top of a pg_dump support for
> > table am. It contains changes to use NULL as a default value for owner / defn /
> > dropStmt (exactly what we've changed back in 19455c9f56), and doesn't crash,
> > since K_VERS is different.
>
> I think this is an open item; we were supposed to do it right after
> 3b925e905de3, but failed to notice.
>
> Would anybody be too upset if I push this patch now? CC'ed RMT.

I think that'd make sense. The rest of the RMT probably isn't awake
however, so I think it'd be good to give them 24h to object.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-04-25 20:02:03 Re: REINDEX INDEX results in a crash for an index of pg_class since 9.6
Previous Message Andres Freund 2019-04-25 19:51:30 Re: REINDEX INDEX results in a crash for an index of pg_class since 9.6