| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> |
| Cc: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>, Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Allow insert and update tuple routing and COPY for foreign table |
| Date: | 2019-04-22 20:27:03 |
| Message-ID: | 20190422202703.4mgtqv3mqtamsgel@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Hi,
On 2019-04-22 21:37:25 +0200, Laurenz Albe wrote:
> Subject: [PATCH] Foreign table COPY FROM and tuple routing requires
> BeginForeignInsert
>
> Commit 3d956d956a introduced support for foreign tables as partitions
> and COPY FROM on foreign tables.
>
> If a foreign data wrapper supports data modifications, but either has
> not adapted to this change yet or doesn't want to support it
> for other reasons, it probably got broken by the above commit,
> because COPY will just call ExecForeignInsert anyway, which might not
> work because neither PlanForeignModify nor BeginForeignModify have
> been called.
>
> To avoid breaking third-party foreign data wrappers in that way, allow
> COPY FROM and tuple routing for foreign tables only if the foreign data
> wrapper implements BeginForeignInsert.
Isn't this worse though? Before this it's an API change between major
versions. With this it's an API change in a *minor* version. Sure, it's
one that doesn't crash, but it's still a pretty substantial function
regression, no?
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Laurenz Albe | 2019-04-22 20:46:00 | Re: pgsql: Allow insert and update tuple routing and COPY for foreign table |
| Previous Message | Robert Haas | 2019-04-22 20:24:15 | Re: pgsql: Allow insert and update tuple routing and COPY for foreign table |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2019-04-22 20:43:17 | Re: pg_dump is broken for partition tablespaces |
| Previous Message | Robert Haas | 2019-04-22 20:24:15 | Re: pgsql: Allow insert and update tuple routing and COPY for foreign table |