Re: Cleanup/remove/update references to OID column

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Daniel Verite <daniel(at)manitou-mail(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Cleanup/remove/update references to OID column
Date: 2019-04-18 04:14:13
Message-ID: 20190418041413.GK2854@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 17, 2019 at 05:51:15PM -0700, Andres Freund wrote:
> Hi,
>
> On 2019-04-17 19:42:19 -0500, Justin Pryzby wrote:
> > diff --git a/doc/src/sgml/information_schema.sgml b/doc/src/sgml/information_schema.sgml
> > index 234a3bb..9c618b1 100644
> > --- a/doc/src/sgml/information_schema.sgml
> > +++ b/doc/src/sgml/information_schema.sgml
> > @@ -1312,8 +1312,8 @@
> > <para>
> > The view <literal>columns</literal> contains information about all
> > table columns (or view columns) in the database. System columns
> > - (<literal>ctid</literal>, etc.) are not included. Only those columns are
> > - shown that the current user has access to (by way of being the
> > + (<literal>ctid</literal>, etc.) are not included. The only columns shown
> > + are those to which the current user has access (by way of being the
> > owner or having some privilege).
> > </para>
>
> I don't see the point of this change? Nor what it has to do with oids?

It doesn't have to do with oids, but seems more correct and cleaner...to my
eyes.

> > - <replaceable>rows</replaceable> was exactly one and the target table was
> > + <replaceable>count</replaceable> was exactly one and the target table was
> The <replacable>rows</<replacable> reference is from your change
> :(.

Ouch, not sure how I did that..sorry for the noise (twice).

Thanks,
Justin

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2019-04-18 04:30:46 Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid
Previous Message Tom Lane 2019-04-18 03:54:49 Re: ALTER TABLE with ADD COLUMN and ADD PRIMARY KEY USING INDEX throws spurious "column contains null values"