Re: Accidental setting of XLogReaderState.private_data ?

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Antonin Houska <ah(at)cybertec(dot)at>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Accidental setting of XLogReaderState.private_data ?
Date: 2019-04-16 06:13:00
Message-ID: 20190416061300.GH2673@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Apr 15, 2019 at 11:06:18AM -0400, Tom Lane wrote:
> Hmm. The second, duplicate assignment is surely pointless, but I think
> that setting the ctx as the private_data is a good idea. It hardly seems
> out of the question that it might be needed in future.

Agreed that we should keep the assignment done with
XLogReaderAllocate(). I have committed the patch which removes the
useless assignment though.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-04-16 06:19:00 Re: REINDEX CONCURRENTLY 2.0
Previous Message Michael Paquier 2019-04-16 05:53:12 Re: Autovacuum-induced regression test instability