Re: pgsql: Consistently test for in-use shared memory.

From: Noah Misch <noah(at)leadboat(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Consistently test for in-use shared memory.
Date: 2019-04-16 01:18:30
Message-ID: 20190416011830.GB3296237@rfd.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Mon, Apr 15, 2019 at 09:01:45PM -0400, Tom Lane wrote:
> Noah Misch <noah(at)leadboat(dot)com> writes:
> >> Perhaps I should write the 'SELECT 1 + 1' to a regular file and redirect input
> >> from that file.
>
> Actually ... we don't need to run a query at all do we?

No. We expect never to run one; it was there for the unexpected case of
"postgres --single" startup succeeding. I pushed a change to close the stdin
of "postgres --single" instead of writing to it. I probably worried that
"postgres --single" would not tolerate that, but it seems to.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-04-16 01:34:55 Re: pgsql: Consistently test for in-use shared memory.
Previous Message Noah Misch 2019-04-16 01:14:36 pgsql: Don't write to stdin of a test process that could have already e