Re: setLastTid() and currtid()

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andres Freund <andres(at)anarazel(dot)de>, "Inoue, Hiroshi" <h-inoue(at)dream(dot)email(dot)ne(dot)jp>, pgsql-hackers(at)postgresql(dot)org, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>, pgsql-odbc(at)postgresql(dot)org
Subject: Re: setLastTid() and currtid()
Date: 2019-04-11 17:52:08
Message-ID: 20190411175208.GA21562@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-odbc

On 2019-Apr-11, Tom Lane wrote:

> Andres Freund <andres(at)anarazel(dot)de> writes:
> > On 2019-03-27 10:01:08 +0900, Inoue, Hiroshi wrote:
> >> The above code remains only for PG servers whose version < 8.2.
> >> Please remove the code around setLastTid().
>
> > Does anybody else have concerns about removing this interface? Does
> > anybody think we should have a deprecation phase? Should we remove this
> > in 12 or 13?
>
> I think removing it after feature freeze is not something to do,
> but +1 for nuking it as soon as the v13 branch opens. Unless
> there's some important reason we need it to be gone in v12?

Umm ... I'm not sure I agree. We're in feature freeze, not code freeze,
and while we're not expecting to have any new feature patches pushed,
cleanup for features that did make the cut is still fair game. As I
understand, this setLastTid stuff would cause trouble if used with a
non-core table AM. Furthermore, if nothing uses it, what's the point of
keeping it?

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-04-11 17:52:20 Re: setLastTid() and currtid()
Previous Message Robbie Harwood 2019-04-11 17:40:49 Re: [PATCH v20] GSSAPI encryption support

Browse pgsql-odbc by date

  From Date Subject
Next Message Andres Freund 2019-04-11 17:52:20 Re: setLastTid() and currtid()
Previous Message Tom Lane 2019-04-11 17:27:03 Re: setLastTid() and currtid()