| From: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | masao(dot)fujii(at)gmail(dot)com |
| Cc: | sawada(dot)mshk(at)gmail(dot)com, rjuju123(at)gmail(dot)com, tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com, alvherre(at)2ndquadrant(dot)com, andres(at)anarazel(dot)de, tgl(at)sss(dot)pgh(dot)pa(dot)us, robertmhaas(at)gmail(dot)com, david(at)pgmasters(dot)net, bossartn(at)amazon(dot)com, andrew(dot)dunstan(at)2ndquadrant(dot)com, michael(at)paquier(dot)xyz, laurenz(dot)albe(at)cybertec(dot)at, k(dot)jamison(at)jp(dot)fujitsu(dot)com, amit(dot)kapila16(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: reloption to prevent VACUUM from truncating empty pages at the end of relation |
| Date: | 2019-04-10 01:58:42 |
| Message-ID: | 20190410.105842.40849442.horiguchi.kyotaro@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Wed, 10 Apr 2019 02:00:03 +0900, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote in <CAHGQGwGufa=f4RWAscOyz1J76Gs-u+wmUt6oZF8YswLiMF13Ew(at)mail(dot)gmail(dot)com>
> On Tue, Apr 9, 2019 at 1:07 PM Kyotaro HORIGUCHI
> <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> >
> > Hello.
> >
> > At Mon, 8 Apr 2019 19:22:04 +0900, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote in <CAHGQGwHa_dX=dRcbR5QVTs6W5mgCy3qZ2fEwREaiXpES1B2+jw(at)mail(dot)gmail(dot)com>
> > > > "TRUNCATE" option for vacuum command should be added to the open items?
> > >
> > > Yes, I think.
> > > Attached is the patch which adds TRUNCATE option into VACUUM.
> >
> > By the way, this might have been discussed upthread, but boolean
> > options of VACUUM command is defaulted to true. So, it seems to
> > me that the name is better (or convenient to me) to be
> > SKIP_TRUNCATE. The name of the reloption seems good to me.
>
> If we really use SKIP_TRUNCATE, we need to use SKIP_INDEX_CLEANUP
> instead of INDEX_CLEANUP for the consistency. But TRUNCATE and
> INDEX_CLEANUP look more intuitive to me than SKIP_TRUNCATE and
> SKIP_INDEX_CLEANUP.
Ah, yes, we already have INDEX_CLEANUP. I'm fine with TRUNCATE.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2019-04-10 02:17:53 | Re: Problem with default partition pruning |
| Previous Message | Kyotaro HORIGUCHI | 2019-04-10 01:53:17 | Re: Possibly-crazy idea for getting rid of some user confusion |