| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | "Liu, Huailing" <liuhuailing(at)cn(dot)fujitsu(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: fix the spelling mistakes of comments |
| Date: | 2019-04-05 01:43:41 |
| Message-ID: | 20190405014341.GB2253@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 04, 2019 at 07:57:02AM -0400, Robert Haas wrote:
> On Wed, Apr 3, 2019 at 6:55 AM Liu, Huailing <liuhuailing(at)cn(dot)fujitsu(dot)com> wrote:
>> * This module contains the code for waiting and release★ of backends.
>> * All code in this module executes on the primary. The core streaming
>> * replication transport remains within WALreceiver/WALsender modules.
>>
>> I think the word marked★ should be 'releasing'.
>
> It could be changed, but I don't think it's really wrong as written.
Indeed.
> > * Walk★ the specified queue from head. Set the state of any backends that
> >
> > I think the word marked★ should be 'Wake'.
>
> I think it's correct as written.
Yes, it's correct as-is. The code *walks* through the shmem queue to
*wake* some of its elements.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tsunakawa, Takayuki | 2019-04-05 01:52:36 | RE: Speed up transaction completion faster after many relations are accessed in a transaction |
| Previous Message | Michael Paquier | 2019-04-05 01:40:34 | Re: pg_rewind vs superuser |