| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Surafel Temesgen <surafel3000(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Adam Berlin <berlin(dot)ab(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> |
| Subject: | Re: COPY FROM WHEN condition |
| Date: | 2019-04-04 19:04:28 |
| Message-ID: | 20190404190428.5ep4mrvqmgh24ykr@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-04-03 22:20:00 -0700, Andres Freund wrote:
> Hi,
>
> On 2019-04-03 20:00:09 +1300, David Rowley wrote:
> > Oops, I forgot about that one. v4 attached.
>
> I'm pretty happy with this. I'm doing some minor changes (e.g. don't
> like the function comment formatting that much, the tableam callback
> needs docs, stuff like that), and then I'm going to push it tomorrow.
After another read, I also think I'm going to rename the functions a
bit. CopyMultiInsertInfo_SetupBuffer, with its mix of camel-case and
underscores, just doesn't seem to mix well with copy.c and also just
generally other postgres code. I feel we already have too many different
naming conventions...
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2019-04-04 19:05:16 | Re: [PATCH v20] GSSAPI encryption support |
| Previous Message | Alvaro Herrera | 2019-04-04 19:01:26 | Re: query logging of prepared statements |