On Wed, Mar 27, 2019 at 12:13:16PM +0900, Michael Paquier wrote:
> ParseExprKind is an enum, so listing all the options without the
> default has the advantage to generate a warning if somebody adds a
> value. This way anybody changing this code will need to think about
> it.
A bit late, but committed without the case/default.
>> ... The value
>> is any variable-free expression (in particular, cross-references
>> to other columns in the current table are not allowed). Subqueries
>> are not allowed either.
>
> Okay, I think I see your point here. That sounds sensible.
And I have used this suggestion from Tom as well for the docs.
--
Michael