| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Amit Langote <amitlangote09(at)gmail(dot)com>, exclusion(at)gmail(dot)com, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Subject: | Re: BUG #15668: Server crash in transformPartitionRangeBounds |
| Date: | 2019-03-22 05:09:57 |
| Message-ID: | 20190322050957.GT20192@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Wed, Mar 20, 2019 at 06:17:27PM +0900, Michael Paquier wrote:
> The thing is that in order to keep the tests for the crash, we finish
> with the inintuitive RTE-related errors, so it is also inconsistent to
> not group things..
As I have seen no feedback from others regarding the changes in error
messages depending on the parsing context, so I have been looking at
splitting the fix for the crash and changing the error messages, and
attached is the result of the split (minus the commit messages). The
first patch fixes the crash, and includes test cases to cover the
crash as well as extra cases for list and range strategies with
partition bounds. Some of the error messages are confusing, but that
fixes the issue. This is not the most elegant thing without the
second patch, but well that could be worse.
The second patch adds better error context for the different error
messages, and includes tests for default expressions, which we could
discuss in a separate thread. So I am not proposing to commit that
without more feedback.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-crash-in-partition-bounds.patch | text/x-diff | 9.2 KB |
| 0002-Rework-error-messages-for-incorrect-column-reference.patch | text/x-diff | 14.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2019-03-22 05:49:42 | Re: BUG #15668: Server crash in transformPartitionRangeBounds |
| Previous Message | David Rowley | 2019-03-22 04:20:07 | Re: BUG #15572: Misleading message reported by "Drop function operation" on DB with functions having same name |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-03-22 05:34:38 | Re: Fwd: Add tablespace tap test to pg_rewind |
| Previous Message | Masahiko Sawada | 2019-03-22 05:02:36 | Re: [HACKERS] Block level parallel vacuum |