Re: pgsql: Make heap TID a tiebreaker nbtree index column.

From: Andres Freund <andres(at)anarazel(dot)de>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Make heap TID a tiebreaker nbtree index column.
Date: 2019-03-20 18:09:34
Message-ID: 20190320180934.kkvnmpsa7my47ffd@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi,

On 2019-03-20 11:00:06 -0700, Peter Geoghegan wrote:
> On Wed, Mar 20, 2019 at 10:05 AM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> > Make heap TID a tiebreaker nbtree index column.
>
> I see that this has caused SELinux test failures on rhinoceros (the
> ddl test fails). It looks like the output order is affected by the
> implementation details of nbtree, likely for some system catalog
> index. This is something that I've had to deal with in other places
> (with a lot of help from Tom).
>
> It's not easy for me to set up SELinux to fix the issue. Is there
> somebody comfortable with that area that could confirm I have it
> right, and provide me with the actual test output? Or push a fix
> themselves?

FWIW, I just fix up the tests using the regression output from
rhinoceros when that happens. Sometimes takes more than a single round,
but it builds frequently enough...

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2019-03-20 18:30:18 Re: pgsql: Make heap TID a tiebreaker nbtree index column.
Previous Message Tom Lane 2019-03-20 18:08:03 Re: pgsql: Make heap TID a tiebreaker nbtree index column.