Re: pgsql: Beautify initialization of JsonValueList and JsonLikeRegexContex

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Alexander Korotkov <akorotkov(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Beautify initialization of JsonValueList and JsonLikeRegexContex
Date: 2019-03-18 04:12:00
Message-ID: 20190318041200.GE1885@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Sun, Mar 17, 2019 at 03:09:07PM +0300, Alexander Korotkov wrote:
> Anyway, I thought about this as about just beautification. If it's
> bad idea, let's revert this.

I agree with Peter's point here that having {0} as initial state is
cleaner instead of adding an extra level of abstraction.
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alexander Korotkov 2019-03-18 06:55:21 pgsql: Revert 4178d8b91c
Previous Message Michael Paquier 2019-03-18 04:01:55 pgsql: Refactor more code logic to update the control file