| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Sergei Kornilov <sk(at)zsrv(dot)org> |
| Cc: | Michael Banck <michael(dot)banck(at)credativ(dot)de>, Magnus Hagander <magnus(at)hagander(dot)net>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Offline enabling/disabling of data checksums |
| Date: | 2019-03-13 22:47:42 |
| Message-ID: | 20190313224742.GA3493@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 13, 2019 at 02:43:39PM +0300, Sergei Kornilov wrote:
> Seems good. And I think we need backpath this check to pg11. similar
> to cross-version compatibility checks
+ fprintf(stderr, _("%s: data directory block size %d is different to compiled-in block size %d.\n"),
+ progname, ControlFile->blcksz, BLCKSZ);
The error message looks grammatically a bit weird to me. What about
the following? Say:
"database block size of %u is different from supported block size of
%u."
Better ideas are welcome.
Please note that hose integers are unsigned by the way.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2019-03-13 23:23:54 | Re: Making all nbtree entries unique by having heap TIDs participate in comparisons |
| Previous Message | David Rowley | 2019-03-13 22:12:21 | Re: Inadequate executor locking of indexes |