Re: move hash_any to utils/hash/hashfn.c

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: move hash_any to utils/hash/hashfn.c
Date: 2019-03-11 16:27:47
Message-ID: 20190311162747.GA16196@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2019-Jan-25, Alvaro Herrera wrote:

> Would anybody object too hard if I move hash_any() and friends to
> src/backend/utils/hash/hashfn.c and the declarations to
> src/include/utils/hashutils.h?

Pushed this. I ended up adding an #include of utils/hashutils.h to
access/hash.h, so that any third-party code using hash_any() from the
latter continues to build unbroken. I don't think this is terribly
problematic -- the only issue is that those projects won't become
updated to use the leaner file, but I don't think we care too much about
that. If I do get pushback about this change I can definitely remove
that line and watch the fireworks.

Anyway, let's see what *else* breaks now ...

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2019-03-11 16:43:25 Re: proposal: variadic argument support for least, greatest function
Previous Message Ramanarayana 2019-03-11 16:24:45 Unaccent extension python script Issue in Windows