From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Surafel Temesgen <surafel3000(at)gmail(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_dump multi VALUES INSERT |
Date: | 2019-03-07 12:46:54 |
Message-ID: | 20190307124653.GA13913@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Pushed, thanks!
If anyone is feeling inspired, one additional test we could use is
--rows-per-insert together with --on-conflict-do-nothing.
I made a couple of edits to v17 before pushing,
* rename strtol endptr variable so that it can be used by other strtol
calls, if we ever have them
* use pre-increment in if() test rather than separate line with
post-increment; reduces line count by 2.
* reworded --help output to: "number of rows per INSERT; implies --inserts"
* added one row-ending archputs(")") which makes the repeated
statement-ending archputs() match exactly. (Negligible slowdown, I
expect)
* moved DUMP_DEFAULT_ROWS_PER_INSERT to pg_dump.c from pg_dump.h
* there was a space-before-comma in an error message, even immortalized
in the test expected output.
* remove the rows_per_insert_zero_col dump output file; the test can be
done by adding the table to the rows_per_insert file. Add one more row
to that zero-column table, so that the INSERT .. DEFAULT VALUES test
verifies the case with more than one row.
* changed the rows_per_insert to use 4 rows per insert rather than
three; that improves coverage (table had 9 rows so it was always hitting
the case where a full statement is emitted.)
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Filip Rembiałkowski | 2019-03-07 12:55:20 | Re: Ltree syntax improvement |
Previous Message | Etsuro Fujita | 2019-03-07 12:35:03 | Re: Update does not move row across foreign partitions in v11 |