From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Jeremy Schneider <schnjere(at)amazon(dot)com> |
Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: few more wait events to add to docs |
Date: | 2019-03-07 02:25:10 |
Message-ID: | 20190307022510.GE17293@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Mar 06, 2019 at 11:08:12AM -0800, Jeremy Schneider wrote:
> LWLock order in documentation:
> 1) CamelCase LWLocks: individually named - see lwlocknames.txt
> 2) lowercase LWLocks: tranches
> 2a) SLRUs - see SimpleLruInit() callers on doxygen
> 2b) Shared Buffer (buffer_content, buffer_io)
> 2c) Individually Named - see RegisterLWLockTranches() in lwlock.c
Hm, OK. Perhaps I lack some user insight on the matter. Thanks for
the feedback! Still there are some areas where we could make the
micro-ordering better. For example replication_slot_io and buffer_io
are I/O specific still they get in the middle of the page, still we
want buffer_content close by.
One thing that I think we could do is reorganize at least
alphabetically the section for "Lock". Each item does not really rely
on others. What do you think?
> If anything, I think we might just want to add comments to
> RegisterLWLockTranches() and lwlocknames.txt with links to the doc file
> that needs to be updated whenever a new tranche is added.
Yes, that would surely help.
> Not sure the best place for a comment on SLRUs (is SimpleLruInit a good
> place?)... but I'm kindof hopeful that we're not adding many more new
> SLRUs anyway and that people would bias toward leveraging the buffer
> cache when possible.
A reference at the top of SimpleLruInit() sounds good to me.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2019-03-07 02:25:34 | Re: pg_dump is broken for partition tablespaces |
Previous Message | Amit Langote | 2019-03-07 02:17:11 | Re: BUG #15672: PostgreSQL 11.1/11.2 crashed after dropping a partition table |