Re: pgsql: Use slots in trigger infrastructure, except for the actual invoc

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Use slots in trigger infrastructure, except for the actual invoc
Date: 2019-02-27 17:18:10
Message-ID: 20190227171810.hp5fbm32jrefigcp@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi,

On 2019-02-27 11:35:18 -0500, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > Use slots in trigger infrastructure, except for the actual invocation.
>
> I believe it's this commit that is resulting in my compiler bleating
> about
>
> trigger.c: In function 'afterTriggerInvokeEvents':
> trigger.c:4493: warning: 'rInfo' may be used uninitialized in this function

Hm, yea, I can see why a compiler, especially without doing more
expensive control flow analysis, would get this wrong. Easier to
understand if we NULL initialize rInfo, not just rel, too. Pushed.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-02-27 17:20:16 Re: pgsql: Use slots in trigger infrastructure, except for the actual invoc
Previous Message Andres Freund 2019-02-27 17:18:02 pgsql: Initialize variable to silence compiler warning.