| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Hubert Lubaczewski <depesz(at)depesz(dot)com>, pgsql-hackers mailing list <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Segfault when restoring -Fd dump on current HEAD |
| Date: | 2019-02-27 12:32:17 |
| Message-ID: | 20190227123217.GA27552@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-Feb-27, Dmitry Dolgov wrote:
> > On Tue, Feb 26, 2019 at 11:53 PM Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> >
> > I think it would be better to just put back the .defn = "" (etc) to the
> > ArchiveEntry calls.
>
> Then we should do this not only for defn, but for owner and dropStmt too.
Yeah, absolutely.
> I can
> update the fix patch I've sent before, if it's preferrable approach in this
> particular situation.
I'm not sure we need those changes, since we're forced to update all
callsites anyway.
> But I hope there are no objections if I'll then submit the original
> changes with more consistent null handling separately to make decision
> about them more consciously.
I think we should save such a patch for whenever we next update the
archive version number, which could take a couple of years given past
history. I'm inclined to add a comment near K_VERS_SELF to remind
whoever next patches it.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2019-02-27 12:45:29 | Unneeded parallel safety tests in grouping_planner |
| Previous Message | Andy Fan | 2019-02-27 11:11:54 | some hints to understand the plsql cursor. |